Skip to content

[beta-1.91] fix: use host-tuple for host target subsitution #16032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: rust-1.91.0
Choose a base branch
from
Draft

[beta-1.91] fix: use host-tuple for host target subsitution #16032

wants to merge 1 commit into from

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Oct 1, 2025 •
edited
Loading

Beta backports

In order to make CI pass, the following PRs are also cherry-picked:

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 1, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Oct 1, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.91.0. Please double check that you specified the right target!

@rustbot rustbot added the A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. label Oct 1, 2025
@weihanglo weihanglo mentioned this pull request Oct 1, 2025
Draft
@weihanglo
Copy link
Member Author

Probably better wait for FCP #13051 (comment).

@weihanglo weihanglo mentioned this pull request Oct 4, 2025
Open
@weihanglo
fix: use host-tuple for host target subsitution
564d26d 
The "host" string is ambiguous

* We have `-Zhost-config` that config `[host]` table applies to
  artifacts running on host, such as build scripts and proc macros.
* `host` sounds like the default behavior, whereas `--target host`
  is in the cross-compilation mode: `target/<triple>/debug`.
* We might want to reserve `host` for future use
@weihanglo weihanglo force-pushed the beta-backport-1.91.0 branch from f4c16ec to 564d26d Compare October 5, 2025 00:37
@weihanglo weihanglo marked this pull request as draft October 5, 2025 00:38
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2025
@weihanglo weihanglo mentioned this pull request Oct 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epage epage

Labels
A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weihanglo @rustbot @epage